Re: [PATCH 3/5] pktgen: Add behavior flag names array - pkt_flag_names

From: David Miller
Date: Mon Jan 15 2018 - 13:09:47 EST


From: Dmitry Safonov <dima@xxxxxxxxxx>
Date: Tue, 9 Jan 2018 13:55:33 +0000

> +#define pf(flag) __stringify(flag),
> +char *pkt_flag_names[] = {
> + PKT_FLAGS
> +};
> +#undef pf

This should be static, also you don't use this table in this patch. You
should add the table in the patch that actually uses the table.