Re: [PATCH 4.14 053/118] Revert "Revert "xfrm: Fix stack-out-of-bounds read in xfrm_state_find.""

From: David Miller
Date: Mon Jan 15 2018 - 11:56:20 EST


From: Steffen Klassert <steffen.klassert@xxxxxxxxxxx>
Date: Mon, 15 Jan 2018 14:23:29 +0100

> On Mon, Jan 15, 2018 at 01:34:40PM +0100, Greg Kroah-Hartman wrote:
>> 4.14-stable review patch. If anyone has any objections, please let me know.
>>
>> ------------------
>>
>> From: "David S. Miller" <davem@xxxxxxxxxxxxx>
>>
>>
>> This reverts commit 94802151894d482e82c324edf2c658f8e6b96508.
>>
>> It breaks transport mode when the policy template has
>> wildcard addresses configured.
>>
>> Signed-off-by: David S. Miller <davem@xxxxxxxxxxxxx>
>> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
>
> Hm, this seems to be one revert too much.
>
> commit 94802151894d482e82c324edf2c658f8e6b96508 reverted already
> the buggy commit. Reverting the revert will bring the bug back.

Steffen, in the email where you asked me to revert that is the
commit ID you referenced.

We can drop this, but you need to then tell us whether 4.14 needs
the revert any longer and if so what the correct SHA ID would
be.