Re: [PATCH 0/2] kconfig: 'if' and automatic submenu creation documentation

From: Sam Ravnborg
Date: Sun Jan 14 2018 - 16:01:09 EST


Hi Ulf.

On Sun, Jan 14, 2018 at 12:33:43PM +0100, Ulf Magnusson wrote:
> These together should make the automatic submenu logic a lot clearer.
>
> Ulf Magnusson (2):
> kconfig: Document 'if' flattening logic
> kconfig: Improve auto. menu documentation accuracy
>
> scripts/kconfig/menu.c | 33 +++++++++++++++++++++++++++++----
> 1 file changed, 29 insertions(+), 4 deletions(-)

Very good with extra comments in menu_finalize.
If you can mamage to explain the logic related to select
then even better.

While on the subject on improving readability, then
menu_finalize would benefit from a split in a number of
well named and well documented helper functions.

It would be great if you could try this out.

Sam