Re: [PATCH V4 2/8] perf/x86/intel/uncore: correct fixed counter index check for NHM

From: Thomas Gleixner
Date: Sun Jan 14 2018 - 15:47:47 EST


On Thu, 2 Nov 2017, kan.liang@xxxxxxxxx wrote:

> From: Kan Liang <Kan.liang@xxxxxxxxx>
>
> For Nehalem and Westmere, there is only one fixed counter for W-Box.
> There is no index which is bigger than UNCORE_PMC_IDX_FIXED.
> It is not correct to use >= to check fixed counter.
> The code quality issue will bring problem when new counter index is
> introduced.
>
> Signed-off-by: Kan Liang <Kan.liang@xxxxxxxxx>

Reviewed-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>