Re: [PATCH] x86,perf: Disable intel_bts when PTI

From: Greg KH
Date: Sun Jan 14 2018 - 08:50:30 EST


On Sun, Jan 14, 2018 at 01:54:44PM +0100, Ingo Molnar wrote:
>
> * Greg KH <greg@xxxxxxxxx> wrote:
>
> > On Sun, Jan 14, 2018 at 11:27:13AM +0100, Peter Zijlstra wrote:
> > >
> > > The intel_bts driver does not use the 'normal' BTS buffer we allocated
> > > space for in the cpu_entry_area but instead uses the memory allocated
> > > for the perf AUX buffer.
> > >
> > > This obviously comes apart when using PTI because then the kernel
> > > mapping; which includes that AUX buffer memory; disappears.
> > >
> > > For now disable this driver when PTI is enabled, we'll try and sort
> > > something out later.
> > >
> > > Cc: Alexander Shishkin <alexander.shishkin@xxxxxxxxxxxxxxx>
> > > Reported-by: Vince Weaver <vincent.weaver@xxxxxxxxx>
> > > Reported-by: Robert ÅwiÄcki <robert@xxxxxxxxxxx>
> > > Signed-off-by: Peter Zijlstra (Intel) <peterz@xxxxxxxxxxxxx>
> >
> > Can you add a:
> > Cc: stable <stable@xxxxxxxxxxxxxxx>
> > please?
>
> Note that these fixes are all going into tip:x86/pti, which is still a backporting
> friendly linear set of commits that should all be backported.
>
> So once 99a9dc98ba52 goes upstream, all of v4.14..99a9dc98ba52 the remaining bits
> can go to -stable as well.
>
> Will keep you updated about the latest status periodically, right now the latest
> that is already upstream is:
>
> de791821c295: x86/pti: Rename BUG_CPU_INSECURE to BUG_CPU_MELTDOWN
>
> i.e. all 194 commits in the v4.14..de791821c295 range should be queued up for
> -stable. (And most of them already are.)

I hope I got all of those in that branch already, as I've been watching
it :)

> There are 28 new commits in tip:x86/pti that will (hopefully) go upstream later
> today.

Great, again, thanks for doing it this way, it has made it much easier
for me.

greg k-h