Re: [PATCH 2/2] kasan: clean up KASAN_SHADOW_SCALE_SHIFT usage

From: Andrey Konovalov
Date: Fri Jan 12 2018 - 11:50:04 EST


On Thu, Jan 11, 2018 at 10:59 PM, Andrey Ryabinin
<aryabinin@xxxxxxxxxxxxx> wrote:
>
>
> On 01/11/2018 06:29 PM, Andrey Konovalov wrote:
>
>> diff --git a/arch/arm64/include/asm/kasan.h b/arch/arm64/include/asm/kasan.h
>> index e266f80e45b7..811643fe7640 100644
>> --- a/arch/arm64/include/asm/kasan.h
>> +++ b/arch/arm64/include/asm/kasan.h
>> @@ -27,7 +27,8 @@
>> * should satisfy the following equation:
>> * KASAN_SHADOW_OFFSET = KASAN_SHADOW_END - (1ULL << 61)
>
> Care to update comments as well?

Sure, done in v2.

>
>> */
>> -#define KASAN_SHADOW_OFFSET (KASAN_SHADOW_END - (1ULL << (64 - 3)))
>> +#define KASAN_SHADOW_OFFSET (KASAN_SHADOW_END - (1ULL << \
>> + (64 - KASAN_SHADOW_SCALE_SHIFT)))
>>
>> void kasan_init(void);
>> void kasan_copy_shadow(pgd_t *pgdir);