Re: [PATCH v8.1 12/12] x86/retpoline: Fill return stack buffer on vmexit

From: Woodhouse, David
Date: Fri Jan 12 2018 - 06:26:06 EST


> On Fri, 2018-01-12 at 12:15 +0100, Thomas Gleixner wrote:
> Fair enough. I surely like the below way more than the sloppy hackery from
> Andi which completely removed any form of documentation.

Be nice. Andi has been extremely helpful in testing and finding corner
cases here, and generally keeping me honest â thanks, Andi.

And I'd have done it *precisely* the same way if you hadn't been
whining on IRC about documenting it. There's a ten-line comment right
above it, saying what it's doing and why. The addition of a couple of
tiny /* speculation trap */ comments inline is really not that much of
a benefit. I just did it to shut you up :)

Attachment: smime.p7s
Description: S/MIME cryptographic signature