Re: [PATCH v3 19/27] drm: replace devm_ioremap_nocache with devm_ioremap

From: Yisheng Xie
Date: Fri Jan 12 2018 - 04:37:33 EST


Hi Benjamin ,

On 2018/1/9 17:21, Benjamin Gaignard wrote:
> 2017-12-23 12:01 GMT+01:00 Yisheng Xie <xieyisheng1@xxxxxxxxxx>:
>> > Default ioremap is ioremap_nocache, so devm_ioremap has the same
>> > function with devm_ioremap_nocache, which can just be killed to
>> > save the size of devres.o
> That looks true for arm and arm64 architectures but not, for exemple, for ia64:
> https://elixir.free-electrons.com/linux/v4.15-rc7/source/arch/ia64/mm/ioremap.c
>
> If there is still one architecture doing a difference between cached
> and uncached
> ioremap we can't remove devm_ioremap_nocache...

Right.

>
> This patch only concern arm chipsets so we can apply it but that will
> not help you to
> reduce devres size.

Yes, And sorry for disturb. Please ignore about this patch.

Thanks
Yisheng
>