Re: [PATCH v2] USB: serial: option: add id for Motorola Solutions TETRA PEI

From: Greg KH
Date: Fri Jan 12 2018 - 04:21:56 EST


On Fri, Jan 12, 2018 at 09:27:15AM +0100, Max Schulze wrote:
> Add Motorola Device ID and blacklist entry to the driver usb/serial/option
>
> Signed-off-by: Max Schulze <max.schulze@xxxxxxxxx>
> ---
> v2: reformatted Patch, first version was declined by GK-H's Bot
>
> Thanks for the help, Johan!
>
> To an URB setup request from the host
> bmRequestType: 0x21
> bRequest: 34
> wValue: 0x0003
> wIndex: 0 (0x0000)
> wLength: 0
>
> the device responds with
> URB status: Broken pipe (-EPIPE) (-32)
>
> So blacklisting to avoid the usb_wwan_send_setup in usb_wwan_dtr_rts of usb_wwan.
> Tested now to work with miniterm.py and minicom without errors.
>
> D: Ver= 2.00 Cls=00(>ifc ) Sub=00 Prot=00 MxPS=64 #Cfgs= 1
> P: Vendor=0cad ProdID=9011 Rev=24.16
> S: Manufacturer=Motorola Solutions Inc.
> S: Product=Motorola Solutions TETRA PEI interface
> C: #Ifs= 2 Cfg#= 1 Atr=80 MxPwr=500mA
> I: If#= 0 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=00 Prot=00 Driver=(none)
> I: If#= 1 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=00 Prot=00 Driver=(none)

Why not put all of this information above the --- line?

thanks,

greg k-h