Re: [PATCH] ASoC: sgtl5000: fix powerup/down of micbias-voltage

From: Mark Brown
Date: Thu Jan 11 2018 - 10:07:26 EST


On Thu, Jan 11, 2018 at 09:40:31AM +0100, fischerc@xxxxxxxxxxxxx wrote:

> The mic-bias-voltage should get powered up/down automatically.
> Added missing DAPM_PRE and DAPM_POST widgets to fire up the mic_bias_event function.

> + SND_SOC_DAPM_PRE("MIC_BIAS_PRE", mic_bias_event),
> + SND_SOC_DAPM_POST("MIC_BIAS_POST", mic_bias_event),

I don't understand what this is intended to do. The mic_bias_event()
callback is already hooked up to the Mic Bias supply widget, it should
be invoked whenever the bias is turned on and off already?

Attachment: signature.asc
Description: PGP signature