Re: çå: [PATCH] ION: Sys_heap: fix the incorrect pool->gfp_mask setting

[Laura Abbott]

On 01/09/2018 04:06 AM, Zengtao (B) wrote:
> > -----邮件原件-----
> > 发件人: Dan Carpenter [mailto:dan.carpenter@xxxxxxxxxx]
> > 发送时间: 2018年1月9日 17:14
> > 收件人: Chenfeng (puck) <puck.chen@xxxxxxxxxxxxx>
> > 抄送: Zengtao (B) <prime.zeng@xxxxxxxxxxxxx>; labbott@xxxxxxxxxx;
> > sumit.semwal@xxxxxxxxxx; gregkh@xxxxxxxxxxxxxxxxxxx; arve@xxxxxxxxxxx;
> > tkjos@xxxxxxxxxxx; maco@xxxxxxxxxxx; devel@xxxxxxxxxxxxxxxxxxxx;
> > linux-kernel@xxxxxxxxxxxxxxx
> > 主题: Re: [PATCH] ION: Sys_heap: fix the incorrect pool->gfp_mask setting
> >
> > On Tue, Jan 09, 2018 at 11:30:09AM +0800, Chen Feng wrote:
> > > On 2018/1/9 18:43, Zeng Tao wrote:
> > > > This issue is introduced by the commit <e7f63771b60e> ("ION: Sys_heap:
> > > > Add cached pool to spead up cached buffer alloc"),
> >
> > Use the Fixes tag.
> >
> > Fixes: e7f63771b60e ("ION: Sys_heap: Add cached pool to spead up cached
> > buffer alloc")
> Agree, thanks.

If you're going to be fixing this, it would be good to
fix the other problems pointed out (stop with the
#define of the flags).

Thanks,
Laura