RE: [RFC PATCH] drivers: soc: xilinx: Add ZynqMP power domain driver

From: Jolly Shah
Date: Wed Jan 10 2018 - 14:58:37 EST


Thanks Philippe for review,

> -----Original Message-----
> From: Philippe Ombredanne [mailto:pombredanne@xxxxxxxx]
> Sent: Tuesday, January 09, 2018 4:48 AM
> To: Jolly Shah <JOLLYS@xxxxxxxxxx>
> Cc: Matthias Brugger <matthias.bgg@xxxxxxxxx>; Andy Gross
> <andy.gross@xxxxxxxxxx>; Shawn Guo <shawnguo@xxxxxxxxxx>;
> geert+renesas@xxxxxxxxx; Bjorn Andersson <bjorn.andersson@xxxxxxxxxx>; Sean
> Wang <sean.wang@xxxxxxxxxxxx>; Marek Szyprowski
> <m.szyprowski@xxxxxxxxxxx>; Michal Simek <michal.simek@xxxxxxxxxx>;
> moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE <linux-arm-
> kernel@xxxxxxxxxxxxxxxxxxx>; LKML <linux-kernel@xxxxxxxxxxxxxxx>; Jolly Shah
> <JOLLYS@xxxxxxxxxx>; Rajan Vaja <RAJANV@xxxxxxxxxx>
> Subject: Re: [RFC PATCH] drivers: soc: xilinx: Add ZynqMP power domain driver
>
> Jolly,
>
> On Mon, Jan 8, 2018 at 11:12 PM, Jolly Shah <jolly.shah@xxxxxxxxxx> wrote:
> > The zynqmp-genpd driver communicates the usage requirements for
> > logical power domains / devices to the platform FW.
> > FW is responsible for choosing appropriate power states, taking Linux'
> > usage information into account.
> >
> > Signed-off-by: Jolly Shah <jollys@xxxxxxxxxx>
> > Signed-off-by: Rajan Vaja <rajanv@xxxxxxxxxx>
> > ---
>
> <snip>
>
> > --- /dev/null
> > +++ b/drivers/soc/xilinx/zynqmp/pm_domains.c
> > @@ -0,0 +1,343 @@
> > +/*
> > + * ZynqMP Generic PM domain support
> > + *
> > + * Copyright (C) 2014-2017 Xilinx, Inc.
> > + *
> > + * Davorin Mista <davorin.mista@xxxxxxxxxx>
> > + * Jolly Shah <jollys@xxxxxxxxxx>
> > + * Rajan Vaja <rajanv@xxxxxxxxxx>
> > + *
> > + * SPDX-License-Identifier: GPL-2.0+
> > + */
>
> This tag should be on the fist line as this:
>
> // SPDX-License-Identifier: GPL-2.0+
>
> --
> Cordially
> Philippe Ombredanne

Will fix it in next version