Re: [PATCH] kbuild: move cc-option and cc-disable-warning after incl. arch Makefile

[Geert Uytterhoeven]

Hi Yamada-san,

On Sun, Dec 10, 2017 at 6:28 AM, Masahiro Yamada
<yamada.masahiro@xxxxxxxxxxxxx> wrote:
> 2017-11-27 21:25 GMT+09:00 Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>:
>> On Mon, Nov 27, 2017 at 1:15 PM, Masahiro Yamada
>> <yamada.masahiro@xxxxxxxxxxxxx> wrote:
>>> Geert reported commit ae6b289a3789 ("kbuild: Set KBUILD_CFLAGS before
>>> incl. arch Makefile") broke cross-compilation using a cross-compiler
>>> that supports less compiler options than the host compiler.
>>>
>>> For example,
>>>
>>>   cc1: error: unrecognized command line option "-Wno-unused-but-set-variable"
>>>
>>> This problem happens on architectures that setup CROSS_COMPILE in their
>>> arch/*/Makefile.
>>>
>>> Move the cc-option and cc-disable-warning back to the original position,
>>> but keep the Clang target options.
>>>
>>> Fixes: ae6b289a3789 ("kbuild: Set KBUILD_CFLAGS before incl. arch Makefile")
>>> Reported-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
>>> Signed-off-by: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>
>>
>> Thanks for the quick response!
>>
>> Tested-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
>
> Applied to linux-kbuild/fixes.

Any chance this will be fixed in v4.15?
It fixes a regression introduced in v4.15-rc1.

Thanks again!

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds