Re: [PATCH 12/12] watchdog: sp5100_tco: Add support for recent FCH versions

From: Boszormenyi Zoltan
Date: Wed Jan 10 2018 - 03:34:28 EST


I'm trying to remove non-ASCII chars from the mail body in the hope
it reaches the lists... My ISP still adds that X-Spam-Report: header
quoting large part of the mail body without MIME-encoding it.

On 2018-01-04 20:21, Guenter Roeck wrote:
On Thu, Jan 04, 2018 at 01:01:22PM +0100, Boszormenyi Zoltan wrote:
On 2017-12-24 22:04, Guenter Roeck wrote:
Starting with Family 16h Models 30h-3Fh and Family 15h Models 60h-6Fh,
watchdog address space decoding has changed. The cutover point is already
identified in the i2c-piix2 driver, so use the same mechanism.

"i2c-piix4".

Thanks!

Otherwise, I only have an older AMD FX CPU, so I can only test
whether it is not broken there.


That is actually the important test. I tested myself on Ryzen 1700X.

I was able to test on a Kabini APU at work, my AMD FX at home still
needs to be tested. The driver loads properly:

[ 5.620836] sp5100_tco: SP5100/SB800 TCO WatchDog Timer Driver
[ 5.621002] sp5100-tco sp5100-tco: Using 0xfed80b00 for watchdog MMIO address
[ 5.621611] sp5100-tco sp5100-tco: initialized. heartbeat=60 sec (nowayout=1)

echo "1" >/dev/watchdog rebooted the machine after one minute properly.

You can add my Tested-by: line.

Best regards,
Zoltan Boszormenyi