Re: [PATCH] f2fs: handle newly created page when revoking inmem pages

From: Daeho Jeong
Date: Wed Jan 10 2018 - 02:26:02 EST


Hi Chao,

> OriginalÂintentionÂhereÂisÂtoÂrecoverÂstatusÂtoÂtheÂtimingÂbefore
> committingÂatomicÂwrite.ÂAsÂatÂthatÂtimingÂblkaddrÂinÂdnodeÂshouldÂbe
> cur->old_addr(NEW_ADDR),ÂsoÂweÂneedÂtoÂchangeÂtoÂcall:
Â
> f2fs_update_data_blkaddr(&dn,ÂNEW_ADDR);

Ok, I'll change NULL_ADDR to NEW_ADDR.

Thanks,
Â
> Otherwise,ÂmetadataÂwillÂbecomeÂinconsistent,ÂbecauseÂblkaddrÂvalueÂis
> NULL_ADDRÂmeansÂthatÂcurrentÂblockÂisÂnotÂpreallocated,Âbut
> total_valid_block_countÂhasÂalreadyÂbeenÂupdated.ÂRight?
Â
> Thanks,
Â

Â
Â