Re: [patch RFC 3/5] x86/spectre: Prepare for IBRS selection

From: Dave Hansen
Date: Tue Jan 09 2018 - 20:51:58 EST


On 01/09/2018 05:06 PM, Thomas Gleixner wrote:
...
> + case SPECTRE_V2_CMD_RETPOLINE:
> + if (IS_ENABLED(CONFIG_RETPOLINE))
> + goto retpoline_auto;
> + break;
> + }
> + pr_err("kernel not compiled with retpoline; no mitigation available!");
> + return;
> +
> +retpoline_auto:
> + /*
> + * Note: This only takes effect during boot before alternatives
> + * have been patched. Later invocations after late micro code
> + * update wont change the boot selection even if IBRS has not been
> + * made available by the microcode loading.
> + */
> if (boot_cpu_data.x86_vendor == X86_VENDOR_AMD) {
> retpoline_amd:

Should the "IBRS has not been" be "IBRS has been"?