Re: [net-next PATCH] net: fix xdp_rxq_info build issue when CONFIG_SYSFS is not set

From: Guenter Roeck
Date: Tue Jan 09 2018 - 17:57:47 EST


On Tue, Jan 09, 2018 at 11:42:34PM +0100, Jesper Dangaard Brouer wrote:
> The commit e817f85652c1 ("xdp: generic XDP handling of xdp_rxq_info")
> removed some ifdef CONFIG_SYSFS in net/core/dev.c, but forgot to
> remove the corresponding ifdef's in include/linux/netdevice.h.
>
> Fixes: e817f85652c1 ("xdp: generic XDP handling of xdp_rxq_info")
> Reported-by: Guenter Roeck <linux@xxxxxxxxxxxx>
> Signed-off-by: Jesper Dangaard Brouer <brouer@xxxxxxxxxx>

Tested-by: Guenter Roeck <linux@xxxxxxxxxxxx>

> ---
> include/linux/netdevice.h | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
> index 440b000f07f4..b308793c64ce 100644
> --- a/include/linux/netdevice.h
> +++ b/include/linux/netdevice.h
> @@ -1805,12 +1805,9 @@ struct net_device {
> /* Interface address info used in eth_type_trans() */
> unsigned char *dev_addr;
>
> -#ifdef CONFIG_SYSFS
> struct netdev_rx_queue *_rx;
> -
> unsigned int num_rx_queues;
> unsigned int real_num_rx_queues;
> -#endif
>
> struct bpf_prog __rcu *xdp_prog;
> unsigned long gro_flush_timeout;
>