Re: [PATCH] slimbus: Unlock on error path in slim_msg_response()

From: Srinivas Kandagatla
Date: Tue Jan 09 2018 - 04:48:16 EST




On 09/01/18 09:34, Dan Carpenter wrote:
We need to unlock and restore IRQs before returning on this error path.

Fixes afbdcc7c384b0 ("slimbus: Add messaging APIs to slimbus framework")
Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>

diff --git a/drivers/slimbus/messaging.c b/drivers/slimbus/messaging.c
index 755462a4c75e..94818a8427e2 100644
--- a/drivers/slimbus/messaging.c
+++ b/drivers/slimbus/messaging.c
@@ -36,6 +36,7 @@ void slim_msg_response(struct slim_controller *ctrl, u8 *reply, u8 tid, u8 len)
msg = txn->msg;
if (msg == NULL || msg->rbuf == NULL) {
+ spin_unlock_irqrestore(&ctrl->txn_lock, flags);
dev_err(ctrl->dev, "Got response to invalid TID:%d, len:%d\n",
tid, len);
return;


Pl note that there are already some patches in flight which are yet to be merged fixes most of the static checker errors :

This is already fixed at:

https://www.mail-archive.com/linux-kernel@xxxxxxxxxxxxxxx/msg1575798.html