Re: [PATCH V2 2/2] ARM: dts: imx7s: add snvs rtc clock

From: Fabio Estevam
Date: Tue Jan 09 2018 - 04:26:51 EST


Hi Anson,

On Tue, Jan 9, 2018 at 12:51 AM, Anson Huang <Anson.Huang@xxxxxxx> wrote:

> + - clocks
> + Usage: required if SNVS LP RTC requires explicit enablement of clocks
> + Value type: <prop_encoded-array>
> + Definition: A list of phandle and clock specifier pairs describing
> + the clocks required for enabling and disabling SNVS LP RTC.


It is a single clock that is used here, so it would be better to
describe the text as:

Definition: A clock specifier describing the clock required for
enabling and disabling SNVS LP RTC

> + - clock-names
> + Usage: required if SNVS LP RTC requires explicit enablement of clocks
> + Value type: <string>
> + Definition: A list of clock name strings in the same order as the
> + clocks property.

and here you must describe that the name should be "snvs-rtc":

Definition: Clock name string should be "snvs-rtc".