Re: [PATCH net-next 12/20] net: hns3: Add packet statistics of netdev

From: lipeng (Y)
Date: Mon Jan 08 2018 - 21:48:49 EST




On 2018/1/9 9:54, David Miller wrote:
From: Jakub Kicinski <kubakici@xxxxx>
Date: Mon, 8 Jan 2018 17:50:21 -0800

Oh, I only noticed this extra misleading comment now. Unless each queue
has a netdev, I don't see how these are per-queue.
If it isn't per-queue I want this change reverted.

[patch 12/20 ] add statistics of netdev for ethtool -S, netdev may have multi queue.

As discussion here, it is duplicate to add this patch.


I revert [patch 12/20 ] , and then test on my board, HNS3 basic function and ethtool -S work well.

So I think it is OK if you can revert [patch 12/20 ]("net: hns3: Add packet statistics of netdev").


Thanks
Peng Li

.