Re: [PATCH] scsi: mptfusion: use strlcpy() instead of strncpy()

From: Arnd Bergmann
Date: Mon Jan 08 2018 - 11:43:08 EST


On Mon, Jan 8, 2018 at 1:49 PM, Xiongfeng Wang
<wangxiongfeng2@xxxxxxxxxx> wrote:
> From: Xiongfeng Wang <xiongfeng.wang@xxxxxxxxxx>
>
> gcc-8 reports
>
> drivers/message/fusion/mptbase.c: In function 'mpt_display_event_info':
> ./include/linux/string.h:245:9: warning: '__builtin_strncpy' specified
> bound 100 equals destination size [-Wstringop-truncation]
>
> We need to use strlcpy() to make sure the dest string is
> nul-terminated.
>
> Signed-off-by: Xiongfeng Wang <xiongfeng.wang@xxxxxxxxxx>

Looks correct to me,

Acked-by: Arnd Bergmann <arnd@xxxxxxxx>