Re: [PATCH] Staging: greybus: Fix multiple checks for null pointers

From: Johan Hovold
Date: Mon Jan 08 2018 - 09:46:20 EST


On Mon, Jan 08, 2018 at 11:28:13AM +0530, Sumit Pundir wrote:
> Fixes the following coding style issue as noted by checkpatch.pl
> at multiple lines:
>
> Comparison to NULL could be written "!token"
>
> Signed-off-by: Sumit Pundir <pundirsumit11@xxxxxxxxx>

Since you're not really fixing anything here, besides silencing a
checkpatch suggestion when run with the --strict option (or on staging
code), I suggest you reword you commit summary (Subject) to, for
example:

staging: greybus: camera: clean up NULL checks

or similar.

Note that I also added "camera" as a module prefix above.

Thanks,
Johan