Re: [PATCH 1/3] GenWQE: Delete an error message for a failed memory allocation in genwqe_user_vmap()

From: haver
Date: Mon Jan 08 2018 - 07:45:29 EST


Hi Markus,

On 2018-01-08 10:41, SF Markus Elfring wrote:
From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
Date: Mon, 8 Jan 2018 09:37:23 +0100

Omit an extra message for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
---
drivers/misc/genwqe/card_utils.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/misc/genwqe/card_utils.c b/drivers/misc/genwqe/card_utils.c
index 8f2e6442d88b..55c389a9e7d7 100644
--- a/drivers/misc/genwqe/card_utils.c
+++ b/drivers/misc/genwqe/card_utils.c
@@ -593,7 +593,6 @@ int genwqe_user_vmap(struct genwqe_dev *cd, struct
dma_mapping *m, void *uaddr,
sizeof(struct page *) + sizeof(dma_addr_t),
GFP_KERNEL);
if (!m->page_list) {
- dev_err(&pci_dev->dev, "err: alloc page_list failed\n");

Are there different printouts which cover this? I mean the debug printout is not
appearing all the time, it must be enabled, if I remember correctly. So why do
you suggest to remove it?

m->nr_pages = 0;
m->u_vaddr = NULL;
m->size = 0; /* mark unused and not added */

Regards

Frank