Re: [PATCH v17 0/5] ZII RAVE platform driver

From: Lee Jones
Date: Mon Jan 08 2018 - 06:09:57 EST


On Wed, 03 Jan 2018, Andrew Morton wrote:

> On Wed, 3 Jan 2018 09:46:21 +0000 Lee Jones <lee.jones@xxxxxxxxxx> wrote:
>
> > Well I guess we better at least include them in the conversation.
> >
> > Stephen and Andrew added.
> >
> > On Tue, 02 Jan 2018, Andrey Smirnov wrote:
> > > On Tue, Jan 2, 2018 at 7:17 AM, Lee Jones <lee.jones@xxxxxxxxxx> wrote:
> > > > On Wed, 20 Dec 2017, Andrey Smirnov wrote:
> > > >
> > > >> Everyone:
> > > >>
> > > >> This patch series is v17 of the driver for supervisory processor found
> > > >> on RAVE series of devices from ZII. Supervisory processor is a PIC
> > > >> microcontroller connected to various electrical subsystems on RAVE
> > > >> devices whose firmware implements protocol to command/qery them.
> > > >>
> > > >> NOTE:
> > > >>
> > > >> * This driver dependends on crc_ccitt_false(), added by
> > > >> 2da9378d531f8cc6670c7497f20d936b706ab80b in 'linux-next', the patch
> > > >> was pulled in by Andrew Morton and is currently avaiting users, so
> > > >> this series might have to go in through Andrew's tree
> > > >
> > > > Hmm... well that's annoying! I just attempted to merge this set, but
> > > > early build tests fail due to a dependency already merged into -next.
> > > >
> > > > ../drivers/mfd/rave-sp.c:227:25: error:
> > > > implicit declaration of function âcrc_ccitt_falseâ
> > > > [-Werror=implicit-function-declaration]
> > > >
> > > > We need to figure out if either of the following are true:
> > > >
> > > > - Patch [0] can be dropped from Andrew's tree
> > > > - ... and I can take it via the MFD tree instead
>
> Please merge lib-crc-ccitt-add-ccitt-false-crc16-variant.patch via the
> MFD tree, along with its user. Here's my copy:

Thanks Andrew. This has now been done.

--
Lee Jones
Linaro Services Technical Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog