Re: [PATCH v6 01/10] x86/retpoline: Add initial retpoline support

From: David Woodhouse
Date: Mon Jan 08 2018 - 05:53:11 EST


On Mon, 2018-01-08 at 11:45 +0100, Peter Zijlstra wrote:
>
>
> Should this not use local name labels instead?
>
> .macro RETPOLINE_JMP reg:req
> ÂÂÂÂÂÂÂÂcallÂÂÂÂ.Ldo_rop_\@
> .Lspec_trap_\@:
> ÂÂÂÂÂÂÂÂpause
> ÂÂÂÂÂÂÂÂjmp .Lspec_trap_\@
> .Ldo_rop_\@:
> ÂÂÂÂÂÂÂÂmovÂÂÂÂÂ\reg, (%_ASM_SP)
> ÂÂÂÂÂÂÂÂret
> .endm

Not if you want to be able to use them twice in the same .S file.

Attachment: smime.p7s
Description: S/MIME cryptographic signature