Re: [PATCH] pinctrl: mcp23s08: fix irq setup order

[Phil Reid]

On 2/01/2018 17:10, Linus Walleij wrote:
> On Thu, Dec 28, 2017 at 4:19 PM, Dmitry Mastykin <mastichi@xxxxxxxxx> wrote:
>
> > When using mcp23s08 module with gpio-keys, often (50% of boots)
> > it fails to get irq numbers with message:
> > "gpio-keys keys: Unable to get irq number for GPIO 0, error -6".
> > Seems that irqs must be setup before devm_gpiochip_add_data().
> >
> > Signed-off-by: Dmitry Mastykin <mastichi@xxxxxxxxx>
>
> Patch applied, albeit for devel.
>
> Should it be tagged for stable or go into fixes?
I'm no expert on this one, but looking at other drivers they're using a mixture of ordering
for irq setup and devm_gpiochip_add_data() calls.

But should probably go into stable if it is the fix.


--
Regards
Phil Reid