Re: [PATCH 2/2] cpufreq: imx6q: add 696MHz operating point for i.mx6ul

From: Rafael J. Wysocki
Date: Sun Jan 07 2018 - 18:35:21 EST


On Saturday, January 6, 2018 4:05:41 AM CET Anson Huang wrote:
> Hi, Rafael
>
> Best Regards!
> Anson Huang
>
>
> > -----Original Message-----
> > From: rjwysocki@xxxxxxxxx [mailto:rjwysocki@xxxxxxxxx] On Behalf Of Rafael
> > J. Wysocki
> > Sent: 2018-01-05 8:21 PM
> > To: Anson Huang <anson.huang@xxxxxxx>
> > Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; Linux
> > PM <linux-pm@xxxxxxxxxxxxxxx>; Linux Kernel Mailing List <linux-
> > kernel@xxxxxxxxxxxxxxx>; Shawn Guo <shawnguo@xxxxxxxxxx>; Sascha Hauer
> > <kernel@xxxxxxxxxxxxxx>; Fabio Estevam <fabio.estevam@xxxxxxx>; Rob
> > Herring <robh+dt@xxxxxxxxxx>; Mark Rutland <mark.rutland@xxxxxxx>;
> > Russell King - ARM Linux <linux@xxxxxxxxxxxxxxx>; Rafael J. Wysocki
> > <rjw@xxxxxxxxxxxxx>; Viresh Kumar <viresh.kumar@xxxxxxxxxx>; Jacky Bai
> > <ping.bai@xxxxxxx>; A.s. Dong <aisheng.dong@xxxxxxx>
> > Subject: Re: [PATCH 2/2] cpufreq: imx6q: add 696MHz operating point for
> > i.mx6ul
> >
> > On Tue, Jan 2, 2018 at 6:07 PM, Anson Huang <Anson.Huang@xxxxxxx> wrote:
> > > Add 696MHz operating point for i.MX6UL, only for those parts with
> > > speed grading fuse set to 2b'10 supports 696MHz operating point, so,
> > > speed grading check is also added for i.MX6UL in this patch, the clock
> > > tree for each operating point are as below:
> > >
> > > 696MHz:
> > > pll1 696000000
> > > pll1_bypass 696000000
> > > pll1_sys 696000000
> > > pll1_sw 696000000
> > > arm 696000000
> > > 528MHz:
> > > pll2 528000000
> > > pll2_bypass 528000000
> > > pll2_bus 528000000
> > > ca7_secondary_sel 528000000
> > > step 528000000
> > > pll1_sw 528000000
> > > arm 528000000
> > > 396MHz:
> > > pll2_pfd2_396m 396000000
> > > ca7_secondary_sel 396000000
> > > step 396000000
> > > pll1_sw 396000000
> > > arm 396000000
> > > 198MHz:
> > > pll2_pfd2_396m 396000000
> > > ca7_secondary_sel 396000000
> > > step 396000000
> > > pll1_sw 396000000
> > > arm 198000000
> > >
> > > Signed-off-by: Anson Huang <Anson.Huang@xxxxxxx>
> >
> > This doesn't apply for me and in a nontrivial way.
> >
> > What kernel is it against?
>
> I did it based on linux-next, it should be on linux-next-pm branch, I redo
> the patch set V2 based on linux-next-pm, also redo the test,
> sorry for the inconvenience.

But you didn't add the Reviewed-by: tags from Fabio to them.

Was that on purpose or by mistake?

Thanks,
Rafael