RE: [PATCH][scsi-next] scsi: aacraid: remove redundant setting of variable c

From: Raghava Aditya Renukunta
Date: Fri Jan 05 2018 - 11:42:43 EST



> -----Original Message-----
> From: Colin King [mailto:colin.king@xxxxxxxxxxxxx]
> Sent: Friday, January 5, 2018 7:31 AM
> To: dl-esc-Aacraid Linux Driver <aacraid@xxxxxxxxxxxxx>; James E . J .
> Bottomley <jejb@xxxxxxxxxxxxxxxxxx>; Martin K . Petersen
> <martin.petersen@xxxxxxxxxx>; linux-scsi@xxxxxxxxxxxxxxx
> Cc: kernel-janitors@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> Subject: [PATCH][scsi-next] scsi: aacraid: remove redundant setting of
> variable c
>
> EXTERNAL EMAIL
>
>
> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> A previous commit no longer stores the contents of c, so we now have
> a situation where c is being updated but the value is never read. Clean
> up the code by removing the now redundant setting of variable c.
>
> Cleans up clang warning:
> drivers/scsi/aacraid/aachba.c:943:3: warning: Value stored to 'c' is
> never read
>
> Fixes: f4e8708d3104 ("scsi: aacraid: Fix udev inquiry race condition")
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>
> ---
Reviewed-by :Raghava Aditya Renukunta <RaghavaAditya.Renukunta@xxxxxxxxxxxxx>