Re: [PATCH V6] mmc:host:sdhci-pci:Addition of Arasan PCI Controller with integrated phy.

From: Sekhar Nori
Date: Wed Jan 03 2018 - 04:30:46 EST


On Wednesday 03 January 2018 05:41 AM, Atul Garg wrote:
> The Arasan Controller is based on a FPGA platform and has integrated phy
> with specific registers used during initialization and
> management of different modes. The phy and the controller are integrated
> and registers are very specific to Arasan.
>
> Arasan being an IP provider, licenses these IPs to various companies for
> integration of IP in custom SOCs. The custom SOCs define own register
> map depending on how bits are tied inside the SOC for phy registers,
> depending on SOC memory plan and hence will require own platform drivers.
>
> If more details on phy registers are required, an interface document is
> hosted at https: //arasandotcom/NF/eMMC5.1 PHY Programming in Linux.pdf.

Please fix this link (no space after : and arasan.com instead of
arasandotcom etc).

>
> Signed-off-by: Atul Garg <agarg@xxxxxxxxxx>

Apart from the comments given by Adrian, looks good to me.

Reviewed-by: Sekhar Nori <nsekhar@xxxxxx>

Regards,
Sekhar