Re: [PATCH] x86/Kconfig: remove stale comment for ARCH_HAS_REFCOUNT

From: Kees Cook
Date: Tue Jan 02 2018 - 13:07:04 EST


On Fri, Dec 29, 2017 at 11:53 AM, Eric Biggers <ebiggers3@xxxxxxxxx> wrote:
> From: Eric Biggers <ebiggers@xxxxxxxxxx>
>
> ARCH_HAS_REFCOUNT is no longer marked as broken ('if BROKEN'), so remove
> the stale comment regarding it being broken.
>
> Signed-off-by: Eric Biggers <ebiggers@xxxxxxxxxx>
> ---
> arch/x86/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
> index d4fc98c50378..ff4e9cd99854 100644
> --- a/arch/x86/Kconfig
> +++ b/arch/x86/Kconfig
> @@ -55,7 +55,6 @@ config X86
> select ARCH_HAS_GCOV_PROFILE_ALL
> select ARCH_HAS_KCOV if X86_64
> select ARCH_HAS_PMEM_API if X86_64
> - # Causing hangs/crashes, see the commit that added this change for details.
> select ARCH_HAS_REFCOUNT
> select ARCH_HAS_UACCESS_FLUSHCACHE if X86_64
> select ARCH_HAS_SET_MEMORY
> --
> 2.15.1
>

Thanks for the catch!

Acked-by: Kees Cook <keescook@xxxxxxxxxxxx>

-Kees

--
Kees Cook
Pixel Security