Re: [PATCH 4/4] extcon: axp288: Handle reserved charger-type values better

[Chanwoo Choi]

Hi Hans,

On 2017ë 12ì 22ì 21:36, Hans de Goede wrote:
> According to the data sheets all the values not handled in the
> switch-case are "reserved". Update the dev_warn message to reflect
> this and set the cable-type to EXTCON_CHG_USB_SDP (so max 500mA
> current draw) as safe default.
> 
> Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx>
> ---
>  drivers/extcon/extcon-axp288.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/extcon/extcon-axp288.c b/drivers/extcon/extcon-axp288.c
> index cc7c35c7ff02..d60c615f709f 100644
> --- a/drivers/extcon/extcon-axp288.c
> +++ b/drivers/extcon/extcon-axp288.c
> @@ -205,8 +205,8 @@ static int axp288_handle_chrg_det_event(struct axp288_extcon_info *info)
>  		cable = EXTCON_CHG_USB_DCP;
>  		break;
>  	default:
> -		dev_warn(info->dev,
> -			"disconnect or unknown or ID event\n");
> +		dev_warn(info->dev, "unknown (reserved) bc detect result\n");
> +		cable = EXTCON_CHG_USB_SDP;
>  	}
>  
>  no_vbus:
> 

Looks good to me.
Reviewed-by: Chanwoo Choi <cw00.choi@xxxxxxxxxxx>

-- 
Best Regards,
Chanwoo Choi
Samsung Electronics