Re: [PATCH] iio: adc: add driver for ti adc081s/adc101s/adc121s

From: Philippe Ombredanne
Date: Sat Dec 23 2017 - 09:13:51 EST


Milan,

On Sat, Dec 23, 2017 at 12:19 AM, Milan Stevanovic
<milan.o.stevanovic@xxxxxxxxx> wrote:
> Signed-off-by: Milan Stevanovic <milan.o.stevanovic@xxxxxxxxx>

<snip>

May be it is just me, but you may be missing a commit message?

<snip>

> --- /dev/null
> +++ b/drivers/iio/adc/ti-adc081s.c
> @@ -0,0 +1,239 @@
> +/*
> + * TI ADC081S/ADC101S/ADC121S 8/10/12-bit ADC driver
> + *
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.

Could you consider using an SPDX tag here as documented by Thomas in
this patch set [1] ?
This is the new thing for this end of of year and a must have for 2018!

[1] https://lkml.org/lkml/2017/12/4/934

--
Cordially
Philippe Ombredanne