Re: [PATCH 0/7] x86/platform/UV: UV Fix patches for Intel processors

From: Mike Travis
Date: Thu Dec 21 2017 - 13:02:14 EST




On 12/21/2017 7:39 AM, Mike Travis wrote:
Sigh, has any of this been properly build tested? x86-64 allyesconfig produces a
bunch of ugly warnings:

...
I will try this "allyesconfig" though I believe it introduces CONFIG items that cause problems where the resultant kernel doesn't boot on a UV system.  But if building is the only goal, then we can ignore them.

I found the error and it had already been fixed. But somehow during the hand off for submission, an earlier version was included in this patch.
Unfortunately most everyone is out for a mandatory shutdown (I've been working during my last 5 vacation days), so I'm not sure we can push the entire patch set again until the new year.

Here's the small change that fixed these warnings that slipped out:

--- linux.orig/arch/x86/kernel/apic/x2apic_uv_x.c
+++ linux/arch/x86/kernel/apic/x2apic_uv_x.c
@@ -816,7 +816,7 @@ static __init void map_mmioh_high_uv34(i
shift = UVH_RH_GAM_MMIOH_OVERLAY_CONFIG0_MMR_M_IO_SHFT;
n = UVH_RH_GAM_MMIOH_REDIRECT_CONFIG0_MMR_DEPTH;
nasid_mask = UVH_RH_GAM_MMIOH_REDIRECT_CONFIG0_MMR_NASID_MASK;
- } else if (index == 1) {
+ } else {
id = "MMIOH1";
m_overlay = UVH_RH_GAM_MMIOH_OVERLAY_CONFIG1_MMR;
overlay = uv_read_local_mmr(m_overlay);

Would it be possible for you to insert this after...

[PATCH 4/7] x86/platform/UV: Fix GAM MMR changes in UV4A

??

Thanks,
Mike