Re: [PATCH v7 1/3] lib: Add strongly typed 64bit int_sqrt

From: Crt Mori
Date: Wed Dec 20 2017 - 04:36:01 EST


Thanks for suggestions and comments. Respinned v9 with them.

On 19 December 2017 at 17:14, Joe Perches <joe@xxxxxxxxxxx> wrote:
> On Tue, 2017-12-19 at 17:12 +0100, Peter Zijlstra wrote:
>> On Tue, Dec 19, 2017 at 08:09:53AM -0800, Joe Perches wrote:
>> >
>> > I suspect you need to define this as:
>> >
>> > #define int_sqrt64(x) ((u32)int_sqrt(x))
>>
>> What's wrong with using C ?
>
> Duh. Nothing at all.
>
>> static inline u32 int_sqrt64(u64 x)
>> {
>> return int_sqrt(x);
>> }