Re: [PATCH] pinctrl: axp209: dereference pointer after it's been set

From: Linus Walleij
Date: Wed Dec 20 2017 - 03:07:41 EST


On Wed, Dec 13, 2017 at 9:55 AM, Quentin Schulz
<quentin.schulz@xxxxxxxxxxxxxxxxxx> wrote:

> The number of GPIOs is gotten from a field within the structure
> referenced in the of_device.data but it was actually read before it was
> retrieved, thus it was dereferencing a null pointer.
>
> Set the number of GPIOs after retrieving of_device.data.
>
> Fixes: e1190083b89b ("pinctrl: axp209: add support for AXP813 GPIOs")
>
> Signed-off-by: Quentin Schulz <quentin.schulz@xxxxxxxxxxxxxxxxxx>
> Reported-by: MylÃne Josserand <mylene.josserand@xxxxxxxxxxxxxxxxxx>

Patch applied with the tags for test and ACK.

Yours,
Linus Walleij