Re: [PATCH] kfree_rcu() should use the new kfree_bulk() interface for freeing rcu structures

From: Matthew Wilcox
Date: Tue Dec 19 2017 - 14:12:29 EST


On Tue, Dec 19, 2017 at 09:52:27AM -0800, rao.shoaib@xxxxxxxxxx wrote:
> This patch updates kfree_rcu to use new bulk memory free functions as they
> are more efficient. It also moves kfree_call_rcu() out of rcu related code to
> mm/slab_common.c
>
> Signed-off-by: Rao Shoaib <rao.shoaib@xxxxxxxxxx>
> ---
> include/linux/mm.h | 5 ++
> kernel/rcu/tree.c | 14 ----
> kernel/sysctl.c | 40 +++++++++++
> mm/slab.h | 23 +++++++
> mm/slab_common.c | 198 ++++++++++++++++++++++++++++++++++++++++++++++++++++-
> 5 files changed, 264 insertions(+), 16 deletions(-)

You've added an awful lot of code. Do you have any performance measurements
that shows this to be a win?