Re: [PATCH 2/4] sched: cpufreq: Keep track of cpufreq utilization update flags

From: Rafael J. Wysocki
Date: Mon Dec 18 2017 - 12:34:30 EST


On Mon, Dec 18, 2017 at 12:59 PM, Viresh Kumar <viresh.kumar@xxxxxxxxxx> wrote:
> On 18-12-17, 12:35, Rafael J. Wysocki wrote:
>> Well, if SCHED_CPUFRREQ_CLEAR means "this CPU is going to enter the
>> idle loop" really, then it is better to call it
>> SCHED_CPUFRREQ_ENTER_IDLE, for example.
>>
>> SCHED_CPUFRREQ_CLEAR meaning basically "you should clear these flags
>> now" doesn't seem to convey any information to whoever doesn't
>> squirrel the flags in the first place.
>
> Right, but when all the flags are cleared, then we can infer that we
> are going to idle in the most probable case.
>
> Anyway, I will implement RT and DL clear flags as you suggested in the
> next version.

Cool, thanks!