Re: [PATCH 2/3 v5] battery: Add the ThinkPad "Not Charging" quirk

From: Pavel Machek
Date: Mon Dec 18 2017 - 09:47:23 EST


On Sun 2017-12-10 19:05:29, Ognjen Galic wrote:
> The EC/ACPI firmware on Lenovo ThinkPads used to report a status
> of "Unknown" when the battery is between the charge start and
> charge stop thresholds. On Windows, it reports "Not Charging"
> so the quirk has been added to also report correctly.
>
> Now the "status" attribute returns "Not Charging" when the
> battery on ThinkPads is not physicaly charging.
>
> Tested-by: Kevin Locke <kevin@xxxxxxxxxxxxxxx>
> Tested-by: Christoph Böhmwalder <christoph@xxxxxxxxxxxxxx>
> Signed-off-by: Ognjen Galic <smclt30p@xxxxxxxxx>

As mentioned before, it would be nice to add a state "not charging for
battery lifetime reasons" and use it here.

Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Attachment: signature.asc
Description: Digital signature