Re: [linux-sunxi] [PATCH v3 2/3] dt-bindings: media: Add Allwinner V3s Camera Sensor Interface (CSI)

From: Maxime Ripard
Date: Mon Dec 18 2017 - 04:24:56 EST


Hi,

On Mon, Dec 18, 2017 at 04:49:21PM +0800, Yong wrote:
> > > + compatible = "allwinner,sun8i-v3s-csi";
> > > + reg = <0x01cb4000 0x1000>;
> > > + interrupts = <GIC_SPI 84 IRQ_TYPE_LEVEL_HIGH>;
> > > + clocks = <&ccu CLK_BUS_CSI>,
> > > + <&ccu CLK_CSI1_SCLK>,
> >
> > CSI also has an MCLK. Do you need that one?
>
> MCLK is not needed if the front end is not a sensor (like adv7611).
> I will add it as an option.

I guess this should always be needed then. And the driver will make
the decision to enable it or not.

Maxime

--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Attachment: signature.asc
Description: PGP signature