Re: [BISECTED] tpm CLKRUN breaks PS/2 keyboard and touchpad on Braswell system

From: Jarkko Sakkinen
Date: Sat Dec 16 2017 - 12:01:30 EST


On Fri, 2017-12-15 at 10:38 -0700, Jason Gunthorpe wrote:
> On Fri, Dec 15, 2017 at 04:56:30PM +0200, Jarkko Sakkinen wrote:
> > On Thu, Dec 14, 2017 at 12:10:52PM -0700, Jason Gunthorpe wrote:
> > > On Thu, Dec 14, 2017 at 08:08:58PM +0100, Javier Martinez Canillas wrote:
> > >
> > > > Although probably reverting the offending commits is the right thing to do
> > > > until a proper solution is proposed.
> > >
> > > Yes, if a fix is not forthcoming soon Jarkko should revert.
> > >
> >
> > I think I should drop the current patch going to 4.16 and revert the old
> > patch. Do we agree on this?
>
> I think the entire is_bsw thing needs to go, clearly manipulating
> CLKRUN directly was not fully thought out?
>
> Hopefully Intel will come up with a fix patch to preserve PS/2
> functionality and it won't come to a revert..

Agreed.

/Jarkko