FS: EXT4: should we sync error info in __ext4_grp_locked_error?

From: Zhouyi Zhou
Date: Thu Dec 14 2017 - 02:13:24 EST


Hi,
In function __ext4_grp_locked_error, __save_error_info(sb, function, line)
is called to save error info in super block block, but does not sync
that information
to disk to info the subsequence fsck after reboot. The reason, I guess
maybe it is
in locked state.
My question is why not make a call ext4_commit_super(sb, 1) after
ext4_unlock_group(sb, grp) and ext4_handle_error(sb), so that subsequence fsck
after reboot is sure to be well informed.
Forgive my naiveness.
Thanks a lot