Re: [PATCH] platform/x86: dell-rbtn: Block comments use * on subsequent lines

From: Philippe Ombredanne
Date: Wed Dec 13 2017 - 04:28:15 EST


Dhaval,

On Wed, Dec 13, 2017 at 9:23 AM, Dhaval Shah
<dhaval.shah@xxxxxxxxxxxxxxx> wrote:
> Resolved Block comments use * on subsequent lines checkpatch warnings.
> Issue found by checkpatch.
>
> Signed-off-by: Dhaval Shah <dhaval.shah@xxxxxxxxxxxxxxx>
> ---
> drivers/platform/x86/dell-rbtn.c | 26 +++++++++++++-------------
> drivers/platform/x86/dell-rbtn.h | 26 +++++++++++++-------------
> 2 files changed, 26 insertions(+), 26 deletions(-)
>
> diff --git a/drivers/platform/x86/dell-rbtn.c b/drivers/platform/x86/dell-rbtn.c
> index f3afe778001e..cab93c6dcd34 100644
> --- a/drivers/platform/x86/dell-rbtn.c
> +++ b/drivers/platform/x86/dell-rbtn.c
> @@ -1,17 +1,17 @@
> /*
> - Dell Airplane Mode Switch driver
> - Copyright (C) 2014-2015 Pali RohÃr <pali.rohar@xxxxxxxxx>
> -
> - This program is free software; you can redistribute it and/or modify
> - it under the terms of the GNU General Public License as published by
> - the Free Software Foundation; either version 2 of the License, or
> - (at your option) any later version.
> -
> - This program is distributed in the hope that it will be useful,
> - but WITHOUT ANY WARRANTY; without even the implied warranty of
> - MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> - GNU General Public License for more details.
> -*/
> + * Dell Airplane Mode Switch driver
> + * Copyright (C) 2014-2015 Pali RohÃr <pali.rohar@xxxxxxxxx>
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation; either version 2 of the License, or
> + * (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.
> + */

Do you mind using the new SPDX ids instead of this long legalese?
You can check the doc patches from Thomas for details [1]

[1] https://lkml.org/lkml/2017/12/4/934
--
Cordially
Philippe Ombredanne