Re: [PATCH] lib/string: avoid reading beyond src buffer in strscpy

From: Andrey Ryabinin
Date: Tue Dec 12 2017 - 11:02:46 EST


On 12/12/2017 01:19 PM, David Laight wrote:
> From: Andrey Ryabinin
>> Sent: 11 December 2017 16:44
> ...
>> I suppose that depends on which one strscpy() caller you'd want to test.
>> Briefly looking at all current users, it doesn't look like they process huge amounts
>> of data through strscpy(), thus we shouldn't suffer from a slight
>> performance degradation of strscpy().
>
> Don't most of the fast string functions use the same kind of
> optimisations.
> strlen() is very likely to do 64 bit reads and then shifts (etc)
> to determine whether any of the bytes are zero.
>

See for yourself, strscpy() is the only sting function doing this.

> David
>