Re: [PATCH 4/4] checkpatch: add check for tag Co-Developed-by

From: Greg Kroah-Hartman
Date: Fri Dec 08 2017 - 02:42:51 EST


On Fri, Dec 08, 2017 at 10:27:51AM +1100, Tobin C. Harding wrote:
> From: Joe Perches <joe@xxxxxxxxxxx>
>
> Recently signature tag Co-Developed-by was added to the
> kernel (Documentation/process/5.Posting.rst). checkpatch.pl doesn't know
> about it yet. All prior tags used all lowercase characters except for first
> character. Checks for this format had to be re-worked to allow for the
> new tag.
>
> Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
>
> Reviewed-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Tobin C. Harding <me@xxxxxxxx>
> ---
>
> Greg,
>
> This patch has the same brief commit and achieves the same aim as the
> code you reviewed. I'm adding your tag here even though the code is
> totally different. I believe you were reviewing the behaviour of the
> code not the actual logic.

Well, I did read the actual logic, I do know perl :)

Anyway, my reviewed-by still stands here, thanks.

greg k-h