Re: [PATCH 4.4 20/49] usbip: tools: Install all headers needed for libusbip development

From: Ben Hutchings
Date: Thu Dec 07 2017 - 22:57:00 EST


On Thu, 2017-12-07 at 14:07 +0100, Greg Kroah-Hartman wrote:
> 4.4-stable review patch.ÂÂIf anyone has any objections, please let me know.
>
> ------------------
>
> From: Ben Hutchings <ben@xxxxxxxxxxxxxxx>
>
>
> [ Upstream commit c15562c0dcb2c7f26e891923b784cf1926b8c833 ]
>
> usbip_host_driver.h now depends on several additional headers, which
> need to be installed along with it.
>
> Fixes: 021aed845303 ("staging: usbip: userspace: migrate usbip_host_driver ...")
> Fixes: 3391ba0e2792 ("usbip: tools: Extract generic code to be shared with ...")
> Signed-off-by: Ben Hutchings <ben@xxxxxxxxxxxxxxx>
> Acked-by: Shuah Khan <shuahkh@xxxxxxxxxxxxxxx>
> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Sasha Levin <alexander.levin@xxxxxxxxxxx>
> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> ---
> Âtools/usb/usbip/Makefile.am |ÂÂÂÂ3 ++-
> Â1 file changed, 2 insertions(+), 1 deletion(-)
>
> --- a/tools/usb/usbip/Makefile.am
> +++ b/tools/usb/usbip/Makefile.am
> @@ -1,6 +1,7 @@
> ÂSUBDIRS := libsrc src
> Âincludedir = @includedir@/usbip
> Âinclude_HEADERS := $(addprefix libsrc/, \
> - ÂÂÂÂÂusbip_common.h vhci_driver.h usbip_host_driver.h)
> + ÂÂÂÂÂusbip_common.h vhci_driver.h usbip_host_driver.h \
> + ÂÂÂÂÂlist.h sysfs_utils.h usbip_host_common.h)

usbip_host_common.h was added in 4.7 (by the second commit listed
above), soÂfor 4.4 and 3.18 it should not be added to this list.

Ben.

> Âdist_man_MANS := $(addprefix doc/, usbip.8 usbipd.8)
>
>
>
--
Ben Hutchings
Software Developer, Codethink Ltd.