Re: [PATCH v2 1/6] dt: bindings: lp8860: Update bindings for lp8860

From: Dan Murphy
Date: Thu Dec 07 2017 - 18:08:48 EST



Rob
On 12/07/2017 04:43 PM, Rob Herring wrote:
> On Tue, Dec 05, 2017 at 02:43:22PM -0600, Dan Murphy wrote:
>> Update the lp8860 bindings to fix various issues
>> found. Add address-cells and size-cells, rename
>> enable-gpio to enable-gpios, update the node name
>> to the device name and indent the node example.
>>
>> Signed-off-by: Dan Murphy <dmurphy@xxxxxx>
>> ---
>>
>> v2 - New patch
>>
>> .../devicetree/bindings/leds/leds-lp8860.txt | 28 ++++++++++++----------
>> 1 file changed, 16 insertions(+), 12 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/leds/leds-lp8860.txt b/Documentation/devicetree/bindings/leds/leds-lp8860.txt
>> index aad38dd94d4b..1b2fab05ec6a 100644
>> --- a/Documentation/devicetree/bindings/leds/leds-lp8860.txt
>> +++ b/Documentation/devicetree/bindings/leds/leds-lp8860.txt
>> @@ -6,24 +6,28 @@ current sinks that can be controlled by a PWM input
>> signal, a SPI/I2C master, or both.
>>
>> Required properties:
>> - - compatible:
>> + - compatible :
>> "ti,lp8860"
>> - - reg - I2C slave address
>> - - label - Used for naming LEDs
>> + - reg : I2C slave address
>> + - label : Used for naming LEDs
>> + - #address-cells : 1
>> + - #size-cells : 0
>
> This should be added in the next patch when you have child nodes.
>

Ack

> Rob
>


--
------------------
Dan Murphy