Re: [PATCH] net: ethernet: arc: fix error handling in emac_rockchip_probe

From: David Miller
Date: Thu Dec 07 2017 - 13:52:15 EST


From: Branislav Radocaj <branislav@xxxxxxxxxxx>
Date: Thu, 7 Dec 2017 00:07:38 +0100

> If clk_set_rate() fails, we should disable clk before return.
> Found by Linux Driver Verification project (linuxtesting.org).
>
> Signed-off-by: Branislav Radocaj <branislav@xxxxxxxxxxx>

Ok, but this probe routine is very inconsistent in how it handles
clock rate setting failures now.

Above your changes, if the RGMII clk can't have it's rate set, we
just continue.