Re: [PATCH net-next v2 6/8] net: phy: meson-gxl: leave CONFIG_A6 untouched

From: Jerome Brunet
Date: Thu Dec 07 2017 - 11:36:16 EST


On Thu, 2017-12-07 at 16:49 +0100, Andrew Lunn wrote:
> On Thu, Dec 07, 2017 at 03:27:13PM +0100, Jerome Brunet wrote:
> > The PHY performs just as well when left in its default configuration and
> > it makes senses because this poke gets reset just after init.
>
> The only thing which might speak against this, is some bootloader
> which sets something other than the default, and here we put it back
> to the value it should have. But if you say a reset will put it back
> to the default value anyway, this seems save.

I was worried about this too bu the bank also gets reset on power down and soft
reset, so we won't get bootloader value at this point

>
> Reviewed-by: Andrew Lunn <andrew@xxxxxxx>
>
> Andrew