Re: [PATCH] mm/slab: Merge adjacent debug sections

From: Christopher Lameter
Date: Thu Dec 07 2017 - 06:17:57 EST


On Thu, 7 Dec 2017, Geert Uytterhoeven wrote:

> --- a/mm/slab.c
> +++ b/mm/slab.c
> @@ -1569,9 +1569,6 @@ static void dump_line(char *data, int offset, int limit)
> }
> }
> }
> -#endif
> -
> -#if DEBUG


Hmmm... This may match at other places. Also there are a lot of #ifdef
DEBUG / #else in that section of the code. Maybe better leave as is? Or
generally rework this into a single #ifdef DEBUG section with all the
debugging code in it and an #else section with all the empty functions.