RE: [PATCH] [linux][master][v1] misc: Add Xilinx ZYNQMP VCU logicoreIP init driver

[Dhaval Rajeshbhai Shah]

> -----Original Message-----
> From: Philippe Ombredanne [mailto:pombredanne@xxxxxxxx]
> Sent: Thursday, December 07, 2017 2:07 AM
> To: Dhaval Rajeshbhai Shah <DSHAH@xxxxxxxxxx>
> Cc: Arnd Bergmann <arnd@xxxxxxxx>; Greg Kroah-Hartman
> <gregkh@xxxxxxxxxxxxxxxxxxx>; LKML <linux-kernel@xxxxxxxxxxxxxxx>;
> michal.simek@xxxxxxxxxx; Hyun Kwon <hyunk@xxxxxxxxxx>; Dhaval
> Rajeshbhai Shah <DSHAH@xxxxxxxxxx>
> Subject: Re: [PATCH] [linux][master][v1] misc: Add Xilinx ZYNQMP VCU
> logicoreIP init driver
> 
> Daval,
> 
> On Tue, Dec 5, 2017 at 12:43 PM, Dhaval Shah <dhaval.shah@xxxxxxxxxx>
> wrote:
> > Xilinx ZYNQMP VCU Init driver is based on the new LogiCoreIP design
> > created. This driver will provide the api which can be used by the
> > encoder and decoder driver to get the configured value.
> >
> > Signed-off-by: Dhaval Shah <dshah@xxxxxxxxxx>
> []
> > diff --git a/drivers/misc/xlnx_vcu.c b/drivers/misc/xlnx_vcu.c new
> > file mode 100644 index 0000000..373f7f9
> > --- /dev/null
> > +++ b/drivers/misc/xlnx_vcu.c
> > @@ -0,0 +1,664 @@
> > +/*
> > + * Xilinx VCU Init
> > + *
> > + * Copyright (C) 2016 - 2017 Xilinx, Inc.
> > + *
> > + * Contacts   Dhaval Shah <dshah@xxxxxxxxxx>
> > + *
> > + * SPDX-License-Identifier: GPL-2.0
> > + */
> 
> The SPDX id should be on the first line with a C++ // style comment instead as
> requested by Linus.
I will take care of this Changes as also suggested by the Greg k-h as well once get the ACK for the remaining reply from the Greg k-h.

Thanks & Regards,
Dhaval
> --
> Cordially
> Philippe Ombredanne